Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message to listitem #331

Closed
martinvandiemen opened this issue Jan 16, 2024 · 9 comments
Closed

Add message to listitem #331

martinvandiemen opened this issue Jan 16, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request in progress

Comments

@martinvandiemen
Copy link

Is your feature request related to a problem? Please describe.
I would like to add a description to the list item.

Describe the solution you'd like
Please description/text/body/message to listitem so that will appear below the title.

Describe alternatives you've considered
Currently I'm using the progresstext but this is only shown when the item is "active".

Additional context
Here is a mockup.
message

@mm2270
Copy link

mm2270 commented Jan 16, 2024

Nice idea, if it's feasible to do. It would add some additional value in using swiftDialog for onboarding, although even in its current state, it's really good for those workflows. Anyway, I like it.

ATM, I use the main message text area for displaying information about the current install, but this seems like a nice improvement.

@bartreardon
Copy link
Collaborator

something like this?

image

@bartreardon bartreardon self-assigned this Jan 21, 2024
@bartreardon bartreardon added enhancement New feature or request in progress labels Jan 21, 2024
@bartreardon
Copy link
Collaborator

available in the latest beta https://github.com/swiftDialog/swiftDialog/releases/tag/v2.0.4.4747

usage:
--listitem "Item Title",subtitle="This is a subtitle"

image

@dan-snelson
Copy link
Collaborator

Noice, Bart!

Screenshot 2024-01-21 at 8 22 01 AM

Looks like the commas which work fine in progresstext don't work so well in subtitle.

(I think I prefer that subtitle not intrude on the area used by status, but how do you know how much room I want for status ? [Probably best to add a dedicate field for subtitle and encourage the admin to "keep it brief.")

@BigMacAdmin
Copy link
Collaborator

Screenshot 2024-01-21 at 12 26 15 PM
I think this looks great.

@martinvandiemen
Copy link
Author

@bartreardon really great. I've tested this but the layout needs a bit more structure. Icon becomes quiet large, alignment looks off, the description is very small and hard to read. Could it maybe be more structured like my mockup? Thanks!

@martinvandiemen
Copy link
Author

I noticed that a description with a comma in it results that the line breaks. Even when escaping the comma \, will still break the line.

@bartreardon
Copy link
Collaborator

If you are specifying the subtitle on the command line then the comma in your text will be interpreted as a separator. If you want more complex text then id recommend using json.

@bartreardon
Copy link
Collaborator

@bartreardon really great. I've tested this but the layout needs a bit more structure. Icon becomes quiet large, alignment looks off, the description is very small and hard to read. Could it maybe be more structured like my mockup? Thanks!

Feel free to submit a PR with how you think it will look. I won't be able to do anything with it until the end of the month anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in progress
Projects
None yet
Development

No branches or pull requests

5 participants