Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating attributes should be decoupled from products #20

Closed
proggeramlug opened this issue Apr 25, 2018 · 1 comment
Closed

Creating attributes should be decoupled from products #20

proggeramlug opened this issue Apr 25, 2018 · 1 comment
Assignees

Comments

@proggeramlug
Copy link
Contributor

The attribute controller/routes should have their own identity.

So we should have routes like
attributes/create
attributes/update
attributes (list)

etc. that deal with the attributes independently of products

likewise when creating an attribute for a product it should link to the ID of attribute.
so
POST products/1/attributes should take arguments such as (attributeId,language, value)

@proggeramlug
Copy link
Contributor Author

Man that is fast :D @calebkleveter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants