Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ISO8601DateFormatter for Swift Evolution dates #34

Open
dempseyatgithub opened this issue Mar 9, 2024 · 3 comments
Open

Use ISO8601DateFormatter for Swift Evolution dates #34

dempseyatgithub opened this issue Mar 9, 2024 · 3 comments

Comments

@dempseyatgithub
Copy link

The Swift Evolution proposals.json file is moving to use full ISO 8601 date strings for review period start and end dates.

The default ISO8601DateFormatter will parse the updated date strings without additional configuration.

It appears the only dependency on the current format is the inputDateFormatter in SwiftEvolution.swift. Updating to use ISO8601DateFormatter should address the change.

static var inputDateFormatter = ISO8601DateFormatter()
@kiliankoe
Copy link
Member

Hey James, thanks for the heads-up and issue! I'm super curious how you managed to stumble across this repo.

We'll get it fixed soon for our bot :)

@dempseyatgithub
Copy link
Author

You're welcome.

I searched GitHub for repositories that fetch 'https://download.swift.org/swift-evolution/proposals.json'.

I'm a member of the Swift Website Workgroup and I'm in the process of working on some changes to the generated metadata.

@kiliankoe
Copy link
Member

kiliankoe commented Mar 12, 2024

Ah, that's clever! And cheers for making the effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants