Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dockerfile for Swift 4.2 #115

Merged
merged 1 commit into from Sep 18, 2018
Merged

Add Dockerfile for Swift 4.2 #115

merged 1 commit into from Sep 18, 2018

Conversation

florianreinhart
Copy link
Contributor

Fixes #114.

@florianreinhart florianreinhart force-pushed the swift-4.2 branch 2 times, most recently from 7a287ef to bd53ab5 Compare June 18, 2018 11:01
@florianreinhart florianreinhart force-pushed the swift-4.2 branch 2 times, most recently from 85ef840 to ab8329e Compare July 3, 2018 07:15
@florianreinhart
Copy link
Contributor Author

I'll update this PR for the Swift 4.2 GM once it is released.

@florianreinhart florianreinhart changed the title Add Dockerfile for Swift 4.2 development snapshots Add Dockerfile for Swift 4.2 Sep 16, 2018
@florianreinhart
Copy link
Contributor Author

Updated to the Swift 4.2 release.

I haven't deleted the 4.0 Dockerfile, yet. Let me know if I should create a separate PR for that.

@Andrewangeta
Copy link

Andrewangeta commented Sep 17, 2018 •
edited

@florianreinhart
Can we merge this in? Really excited to start using 4.2 now that it's released. Don't want to have to maintain my own private image anymore :P of the dev snapshots.

@andrewtheis
Copy link

@pepibumur Swift 4.2 released yesterday. Would be great to get this in!

@hamin hamin merged commit 7fbe6bf into apple:master Sep 18, 2018
@hamin
Copy link
Collaborator

hamin commented Sep 18, 2018

thanks @florianreinhart !

@florianreinhart florianreinhart deleted the swift-4.2 branch September 18, 2018 17:31
@florianreinhart
Copy link
Contributor Author

@hamin Thanks! I will now create a PR to the official Docker image repo.

@florianreinhart
Copy link
Contributor Author

docker-library/official-images#4856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepicrft pepicrft pepicrft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@florianreinhart @Andrewangeta @andrewtheis @hamin @pepicrft