Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[L10n] Provide a fallback for UTF8 encoding + better error messages #21

Closed
AliSoftware opened this issue Oct 1, 2015 · 3 comments
Closed

[L10n] Provide a fallback for UTF8 encoding + better error messages #21

AliSoftware opened this issue Oct 1, 2015 · 3 comments
Labels
difficulty: easy type: enhancement
Milestone
0.6.0

Comments

@AliSoftware
Copy link
Collaborator

It seems that Xcode doesn't require anymore for your Localizable.strings to be UTF-16 encoded and also allows UTF8 encoded files. We should fallback to that, or use the Cocoa method that guess the encoding instead. See also #18

It would be a good occasion to improve error messages as well.
@iGranDav
Copy link

iGranDav commented Oct 1, 2015

👍 thanks for the support

@AliSoftware AliSoftware mentioned this issue Oct 1, 2015
Closed
@AliSoftware AliSoftware modified the milestone: 0.7.0 Oct 14, 2015
@AliSoftware
Copy link
Collaborator Author

This should be now fixed in master and will be available in the next release.

Don't hesitate to test the master branch (using git clone + rake install) even before an official version is released to confirm so I can close.

AliSoftware added a commit that referenced this issue Oct 25, 2015
@AliSoftware
Added a fixture to ensure #21 is fixed
e2379cf
@AliSoftware AliSoftware mentioned this issue Oct 25, 2015
Closed
@AliSoftware AliSoftware modified the milestones: 0.7.0, 0.6.0 Oct 25, 2015
@AliSoftware
Copy link
Collaborator Author

0.6.0 fixing this has been submitted to Homebrew rn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy type: enhancement
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
2 participants
@iGranDav @AliSoftware