Implement Path.addArc(tangent1End:...). #526
Conversation
|
Swiftlint is complaining about using |
|
I saw how other snapshot tests are written and think I understand how to write one, but I'm not sure how I can generate a snapshot to compare against. I'll add the snapshot tests later in the week. |
|
I think you could just run the test and copy the image it writes in, then compare against that going forward. Layout tests compare directly against a rendered SwiftUI view. |
|
I realized that my code doesn't really choose the start-end/clockwise combinations correctly. This means that the start of the arc may be on the second tangent and the arc's end will be on the first tangent. So, I'll keep working on this to get everything exactly like the native implementations. |
|
I fixed the issue and added some more tests. However, I was unable to get the project to build so I could run the snapshot tests. I run the following according to the contribution guide to no avail: swift build --product TokamakPackageTests && `xcrun --find xctest` .build/debug/TokamakPackageTests.xctestI’m not sure why, but there seems to be a problem with core-graphics types, such as |
| @@ -65,6 +65,123 @@ final class ShapeRenderingTests: XCTestCase { | |||
| timeout: defaultSnapshotTimeout | |||
| ) | |||
| } | |||
|
|
|||
| func testTangentArc() { | |||
There was a problem hiding this comment.
When running this test, the call stack overflows in getArc where it gets the second chunk:
It seems to make sense, as the
chunk1 angle is created by adding .pi / 2 to the startAngle, which the call to getArc then checks and sees the value is greater than .pi / 2.
Personally I'm not sure what the solution to this is, I'm hoping you have some ideas 🙃
The
addArc(tangent1End:tangent2End:radius:transform:)method was left unimplemented and added nothing to the path components. This implementation uses some vector arithmetic onCGPointto create an arc. There are probably better approaches out there, but I think this a good starting point.