Add Static HTML Renderer and Documentation #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carson-katri
added
documentation
carson-katri
changed the title
|
Maybe put the docs in the |
MaxDesiatov
reviewed
Jul 22, 2020
MaxDesiatov
reviewed
Jul 22, 2020
|
Would you consider adding |
|
Sure no problem. |
carson-katri
force-pushed
the
static-renderer
branch
from
d59bad8
to
c940c29
Compare
MaxDesiatov
previously approved these changes
Aug 1, 2020
MaxDesiatov
reviewed
Aug 1, 2020
docs/Building a Renderer/6 Providing platform-specific primitives.md
Outdated
Show resolved
Hide resolved
MaxDesiatov
previously approved these changes
Aug 1, 2020
j-f1
previously approved these changes
Aug 1, 2020
|
Sorry about the conflicts, I'll get those fixed |
# Conflicts: # Sources/TokamakDOM/DOMRenderer.swift # Sources/TokamakDOM/Views/Buttons/Button.swift
MaxDesiatov
approved these changes
Aug 1, 2020
j-f1
approved these changes
Aug 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this while documenting the process of building a
Renderer. I've attached the markdown files, which could be included in the Wiki.The renderer relies on
TokamakDOMso I didn't have to rewrite the HTML/CSS representations. It currently doesn't supportApp/Scene, but will once that gets merged. I'll also add in how to support that to the Wiki articles.RendererWiki.zip
There's also a new demo
TokamakStaticDemo. You can test the renderer withswift run TokamakStaticDemo.Todo:
AppandSceneTokamakDOMdepends onTokamakStaticTokamakStaticHTML