Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function appendChild(node: Node) return wrong type #48

Open
bestwnh opened this issue Dec 6, 2023 · 0 comments · May be fixed by #52
Open

Function appendChild(node: Node) return wrong type #48

bestwnh opened this issue Dec 6, 2023 · 0 comments · May be fixed by #52

Comments

@bestwnh
Copy link

bestwnh commented Dec 6, 2023

The appendChild(node: Node) for Node return type should be same as the child, not the parent. Now if you use the div element to add a span, it would cause error. I'm currently using a method below instead.

func addNode<T: Node>(_ node: T) -> T {
    let result = self.jsValue.appendChild(node.jsValue)
    return T.init(from: result)!
}
@bestwnh bestwnh changed the title func appendChild(node: Node) return wrong type Func appendChild(node: Node) return wrong type Dec 6, 2023
@bestwnh bestwnh changed the title Func appendChild(node: Node) return wrong type Function appendChild(node: Node) return wrong type Dec 6, 2023
@bestwnh bestwnh linked a pull request May 8, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix append child error bestwnh/WebAPIKit
1 participant
@bestwnh