Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid applying I64ImportTransformer when JS BigInt support is enabled #326

Closed
MaxDesiatov opened this issue May 4, 2022 · 0 comments · Fixed by #338
Closed

Avoid applying I64ImportTransformer when JS BigInt support is enabled #326

MaxDesiatov opened this issue May 4, 2022 · 0 comments · Fixed by #338
Labels
bug Something isn't working

Comments

@MaxDesiatov
Copy link
Collaborator

Having import JavaScriptBigIntSupport and using BigInt/Int64 support with latest JSKit leads to issues when I64ImportTransformer is enabled. We should be able to scan package dependencies to detect if JavaScriptBigIntSupport is linked and disable the transformer pass. If traversing dependency turns out to be too complex or impossible to implement, we could disable the transformation by default altogether, keeping it enabled only when a CLI flag is passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix JavaScriptBigIntSupport compatibility issue swiftwasm/carton
1 participant
@MaxDesiatov