Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: auto-rectify git source url #47

Merged
merged 9 commits into from Oct 6, 2023
Merged

feat: auto-rectify git source url #47

merged 9 commits into from Oct 6, 2023

Conversation

avelynhc
Copy link
Contributor

@avelynhc avelynhc commented Oct 5, 2023

Fixes #36

Describe the changes you have made in this PR

Screenshots of the changes (If any) -

Screenshot 2023-09-29 at 2 08 42 PM

tanmoysrt
tanmoysrt requested changes Oct 5, 2023
View reviewed changes
Copy link
Member

@tanmoysrt tanmoysrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the value of the input box as well .

tanmoysrt
tanmoysrt requested changes Oct 6, 2023
View reviewed changes
src/pages/deploy_application/configure_source.jsx Outdated Show resolved Hide resolved
src/pages/deploy_application/configure_source.jsx Outdated Show resolved Hide resolved
src/pages/deploy_application/configure_source.jsx Outdated Show resolved Hide resolved
@tanmoysrt tanmoysrt changed the title auto-rectify git source url feat: auto-rectify git source url Oct 6, 2023
tanmoysrt
tanmoysrt approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@tanmoysrt tanmoysrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Great job @avelynhc 🔥

@tanmoysrt tanmoysrt merged commit ba29efc into swiftwave-org:master Oct 6, 2023
@avelynhc avelynhc deleted the issue-36 branch October 6, 2023 19:48
@tanmoysrt tanmoysrt added the enhancement New feature or request label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmoysrt tanmoysrt tanmoysrt approved these changes

Assignees

@avelynhc avelynhc

Labels
enhancement New feature or request hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: auto-rectify git source url
2 participants
@avelynhc @tanmoysrt