Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jQuery/moment dependency #10

Closed
ocombe opened this issue Aug 2, 2016 · 7 comments
Closed

Remove jQuery/moment dependency #10

ocombe opened this issue Aug 2, 2016 · 7 comments
Assignees
Labels
Milestone

Comments

@ocombe
Copy link
Contributor

ocombe commented Aug 2, 2016

A few files use jquery/moment functions/helpers, we have to remove these

@ocombe ocombe changed the title Remove jQuery dependency Remove jQuery/moment dependency Aug 2, 2016
@ocombe
Copy link
Contributor Author

ocombe commented Aug 2, 2016

I've removed jQuery / Angular dependencies, but we still have to remove momentjs :)

@amcdnl
Copy link
Contributor

amcdnl commented Aug 2, 2016

@marjan-georgiev what are we using moment for? Pretty naming of dates?

@marjan-georgiev
Copy link
Member

Parsing and formatting. We should be fine without it.

@amcdnl amcdnl added the Backlog label Aug 2, 2016
@amcdnl amcdnl added this to the 1.0.0-beta milestone Aug 2, 2016
@marjan-georgiev
Copy link
Member

jQuery is removed. We are going to keep moment for the time being. It's useful for parsing and formatting dates.

@ocombe
Copy link
Contributor Author

ocombe commented Sep 8, 2016

true, just check if there isn't what you need in D3 itself: https://github.com/d3/d3-time-format

@ajackson-cpi
Copy link

What's the status of removing Moment? It's important for keeping builds small.
Is is possible to indicate which codepaths it's needed, so we can avoid those?

@amcdnl
Copy link
Contributor

amcdnl commented Nov 28, 2016

@marjan-georgiev - what do we use moment for?

@Markus-ipse Markus-ipse mentioned this issue Jan 20, 2017
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants