Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with link generation - Error with redrawlines linkselection #41

Closed
kenisteward opened this issue Nov 29, 2017 · 10 comments
Closed

Comments

@kenisteward
Copy link
Contributor

I'm submitting a ... (check one with "x")

[X ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here

Current behavior
Recieve linkselection.attr().transition is not a function due to d3 upgrades
transition

Expected behavior
no error

Reproduction of the problem
https://stackblitz.com/edit/angular-vtavqy

this doesn't show the error but it is definitely not building / showing the edges. In my personal case i get the error

Please tell us about your environment:
defined in the stackblitz

@kenisteward
Copy link
Contributor Author

Possible fix

add

import {transition} from 'd3-transition';

@isaacplmann
Copy link
Contributor

It looks like you're getting pretty close to a solution. Want to submit a PR?

@kenisteward
Copy link
Contributor Author

sure!!!!

@kenisteward
Copy link
Contributor Author

see #43

@kenisteward
Copy link
Contributor Author

resolved with #43

@Wu-Li
Copy link

Wu-Li commented Jul 17, 2023

I'm still getting this error today with the latest version, even if I include d3-transition (or just d3).
ngx-error
Haven't done hardly anything with it, just copied the quick start demo HTML from the docs to test that the newly installed package is working.

@WograTimKoehler
Copy link

@Wu-Li
I don't know if you already found the solution, but as it is mentioned in this issue, it is a problem with the versioning. You can fix it by adding

  "overrides": {
    "d3-selection": "3.0.0"
  },

to your package.json

@Wu-Li
Copy link

Wu-Li commented Jul 19, 2023

That worked, thank you!

@divyrathoreimpetus
Copy link

@kenisteward , is this fix available in 8.2.3. I'm facing this issue there.

@wangruoni
Copy link

same... 8.2.3. still facing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants