Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find name "Matrix" in 4.1.0 #67

Closed
jawadst opened this issue Apr 5, 2018 · 1 comment
Closed

Cannot find name "Matrix" in 4.1.0 #67

jawadst opened this issue Apr 5, 2018 · 1 comment

Comments

@jawadst
Copy link
Contributor

jawadst commented Apr 5, 2018

I'm submitting a ... (check one with "x")

[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here

Current behavior
When compiling an application using the version 4.1.0, I get the following error:
ERROR in node_modules/@swimlane/ngx-graph/release/graph/graph.component.d.ts(49,27): error TS2304: Cannot find name 'Matrix'.

Expected behavior
The application should build without errors

Reproduction of the problem
Any app using the new version and compiled with prod/build-optimizer

I think the issue is that the Matrix type is missing from https://github.com/swimlane/ngx-graph/blob/master/release/graph/graph.component.d.ts

That type is declared here: https://github.com/chrvadala/transformation-matrix/blob/master/transformation-matrix.d.ts

  • ngx-graph version: 4.1.0

  • Angular version: 5.x.x

  • Browser: Compilation error

  • Language: TS

@jawadst jawadst mentioned this issue Apr 5, 2018
9 tasks
@jawadst
Copy link
Contributor Author

jawadst commented Apr 5, 2018

I think that the issue is that https://github.com/chrvadala/transformation-matrix/blob/master/transformation-matrix.d.ts#L1 has an unexported Matrix type.

I'll ask them to export it but I have a working fix in the interim (just defining the type ourselves): #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant