Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing actions #27

Closed
khambir opened this issue Apr 5, 2017 · 7 comments
Closed

Missing actions #27

khambir opened this issue Apr 5, 2017 · 7 comments
Labels
Milestone

Comments

@khambir
Copy link

khambir commented Apr 5, 2017

I have cell with right and left actions.
Left actions have "fill" expansionStyle and Right have "destructive" expansionStyle.
When left action was performed, the right actions are invisible, I can swiping the cell, actions is performing, but actions button are invisible.

@jerkoch
Copy link
Contributor

jerkoch commented Apr 5, 2017

Thanks @khambir. I'll take a look at this soon!

@jerkoch jerkoch added the bug label Apr 5, 2017
@jerkoch jerkoch closed this as completed in e7e27af Apr 5, 2017
@jerkoch jerkoch added this to the 1.7.1 milestone Apr 5, 2017
@khambir
Copy link
Author

khambir commented Apr 7, 2017

Bug is not fixed.

I have 2 buttons:
screen shot 2017-04-07 at 3 56 43 pm

I call left action with expansionStyle .fill
screen shot 2017-04-07 at 3 57 11 pm

Buttons from right were missing.
screen shot 2017-04-07 at 3 57 33 pm

@jerkoch
Copy link
Contributor

jerkoch commented Apr 7, 2017

Hey @khambir - Can you confirm you're using the latest from the develop branch?

@khambir
Copy link
Author

khambir commented Apr 7, 2017

Yes, I updated pod from the develop branch. And double checked, your changes did appear in my project.

@jerkoch
Copy link
Contributor

jerkoch commented Apr 7, 2017

Hmm... 🤔

It seems like the mask is still not getting reset somehow. Can you paste your relevant delegate code or provide a small sample project?

@khambir
Copy link
Author

khambir commented Apr 7, 2017

swipeProject.zip

@jerkoch
Copy link
Contributor

jerkoch commented Apr 7, 2017

Hey @khambir - The issue was that you're not called action.fulfill(style: .reset) from your action handler. Fill expansions aren't autofulfilling. See the README for more details.

I made a change that will fix this even if you don't call action.fulfill(style: .reset), but you should still add it on your end. 👍

@jerkoch jerkoch modified the milestones: 1.8.0, 1.7.1 Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants