Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling a sub item #41

Closed
jpimag opened this issue May 2, 2012 · 1 comment
Closed

Disabling a sub item #41

jpimag opened this issue May 2, 2012 · 1 comment

Comments

@jpimag
Copy link

jpimag commented May 2, 2012

I use HTML5 menu import. When I disable a sub menu item, item's callback is still called on click.

To illustrate, I just disabled a sub item from official HTML import demo :



<menu id="html5menu" type="context" style="display:none" class="showcase">
<command label="rotate" onclick="alert('rotate')">
<command label="resize" onclick="alert('resize')">
<menu label="share">
<command label="twitter" onclick="alert('twitter')" disabled="true">
<hr>
<command label="facebook" onclick="alert('facebook')">
</menu>
</menu>

thanks

rodneyrehm added a commit that referenced this issue May 2, 2012
@rodneyrehm
Copy link
Contributor

For some reason clicking on a sub-menu item would trigger the first element of that sub-menu. due to bubbling events this would always happen for disabled elements. I fixed that with version 1.5.12. thanks for the catch!

baohx2000 pushed a commit to Contatta/jQuery-contextMenu that referenced this issue Jun 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants