Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't compile against new AGPL SeisComP: Seiscomp::Array’ has no member named ‘bytes’ #28

Closed
luca-s opened this issue May 4, 2020 · 8 comments
Labels
maintenance maintenance

Comments

@luca-s
Copy link
Contributor

luca-s commented May 4, 2020

The code currently compiles only with SeisComp3 Release 2018.327.x series.
Since the API changed in the new SeisComP there is no way to make the same code compiles on both the previous and new versions so I will create a new branch soon for differentiate the releases.

Compilation logs:

[ 99%] Built target seiscomp3_rtddmsg
[ 99%] Building CXX object src/rtdd-addons/apps/scrtdd/CMakeFiles/scrtdd.dir/hdd/wfmngr.cpp.o
/home/centos/seiscomp3/src/rtdd-addons/apps/scrtdd/hdd/wfmngr.cpp: In static member function ‘static void Seiscomp::HDD::WfMngr::writeTrace(Seiscomp::GenericRecordCPtr, const string&)’:
/home/centos/seiscomp3/src/rtdd-addons/apps/scrtdd/hdd/wfmngr.cpp:877:57: error: ‘const class Seiscomp::Array’ has no member named ‘bytes’
int reclen = msRec.data()->size()*msRec.data()->bytes() + 64;
^
make[2]: *** [src/rtdd-addons/apps/scrtdd/CMakeFiles/scrtdd.dir/hdd/wfmngr.cpp.o] Error 1
make[1]: *** [src/rtdd-addons/apps/scrtdd/CMakeFiles/scrtdd.dir/all] Error 2
make: *** [all] Error 2
@luca-s luca-s added the maintenance maintenance label May 4, 2020
@comoglu
Copy link

comoglu commented May 5, 2020

Hi Luca,
Actually the error message comes with the current seiscomp3 repository, not new SeisComP. I tried again to make sure that I am giving the right information to you.

image

@comoglu
Copy link

comoglu commented May 5, 2020

The compilation is OK when I remove rtdd-addons from the source directory

@luca-s
Copy link
Contributor Author

luca-s commented May 5, 2020

Ah! Thanks for clarifying this. Can you tell me what brach/tag are you using for compilation (maybe the master)? I tested only the old release 2018.327.x. Maybe the new one has the same changes as the new SeisComP.

I am now making some changes, I'll update here when they are done and hopefully your issue will get fixed.

In the meanwhile, you could try the build/jakarta/2018.327 branch (git checkout build/jakarta/2018.327) and that should work.

@comoglu
Copy link

comoglu commented May 5, 2020

This is the output if I used release p19, I will be trying p18 as well when I have time.
image

@luca-s
Copy link
Contributor Author

luca-s commented May 6, 2020

I pushed some commits that fix the compilation errors you encountered. If you update your scrtdd code it should compiles fine now.

@luca-s
Copy link
Contributor Author

luca-s commented May 6, 2020

I forgot; p19 is fine, you don't need to try p18.

@comoglu
Copy link

comoglu commented May 6, 2020

Yep, I am able to compile it with branch 2018.327. I will be following the documentation to see how to use it within seiscomp3 when time allows me to do so.

@luca-s
Copy link
Contributor Author

luca-s commented May 7, 2020

There is now a new branch new_agpl_seiscomp for the new AGPL SeisComP. I will merge it to master when the official launch of the AGPL SeisComP happens.

@luca-s luca-s closed this as completed May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance maintenance
Projects
None yet
Development

No branches or pull requests

2 participants