Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nll] Unweighted RMS computation #12

Closed
luca-s opened this issue Aug 18, 2022 · 4 comments
Closed

[nll] Unweighted RMS computation #12

luca-s opened this issue Aug 18, 2022 · 4 comments

Comments

@luca-s
Copy link
Collaborator

luca-s commented Aug 18, 2022

Following the discussion in here we should consider if we want to compute the RMS in NLL plugin without weighting the residuals by arrival weight.

@luca-s
Copy link
Collaborator Author

luca-s commented Aug 18, 2022

Since changing the RMS computation might be consider a backward inconsistency we could consider to apply this change in the next release of SeisComP when the new NonLinLoc v7 code will land. That is already a big change

@gempa-jabe
Copy link
Collaborator

Will NonLinLoc 7 break catalogues by producing different solutions or different error measures? I am fine with changing the way the RMS is being computed, I just don't know how much it will affect current users.

Actually the name standardError suggests that the determination is kind of standard.

@luca-s
Copy link
Collaborator Author

luca-s commented Aug 18, 2022

Will NonLinLoc 7 break catalogues by producing different solutions or different error measures?

In my comparison tests between current NLL and NLL v7 I got similar results so I expect a transition to NonLinLoc 7 without any backward incompatibilities: neither in behaviour nor in configuration. NLL v7 should be a drop-in replacement to the current version. However I cannot be sure 100% since my testing is limited to my use cases.

I am fine with changing the way the RMS is being computed, I just don't know how much it will affect current users.

That would affect SED for example. So I pointed my collegues to this conversation. However for the sake of consistency I believe we should recompute RMS in a standard way.

@luca-s luca-s changed the title Unweighted RMS computation [nll] Unweighted RMS computation Aug 19, 2022
@luca-s
Copy link
Collaborator Author

luca-s commented Aug 24, 2022

This has been discussed internally at SED and we decided it is not worth changing this metric and it would make future events inconsistent with historical ones.

@luca-s luca-s closed this as completed Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants