Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#163179993 Setup Database #33

Merged
merged 7 commits into from Jan 17, 2019
Merged

Conversation

tunedev
Copy link
Owner

@tunedev tunedev commented Jan 16, 2019

What does this PR do?

Setup Database using postgres

Description of Task to be completed?

Replace data structure with database.

Any background context you want to provide?

A data structure was used for the testing of endpoints before.

What are the relevant pivotal tracker stories?

#163179993

dist/app.js Outdated
@@ -19,7 +19,9 @@ var _question = _interopRequireDefault(require("./routes/question"));

function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

// import dotenv from 'dotenv';
// Import Routes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove your dist files.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have removed it.

Copy link
Collaborator

@chukwuemekachm chukwuemekachm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your commit message to follow the convention.

Copy link
Collaborator

@chukwuemekachm chukwuemekachm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the failing build.

@chukwuemekachm chukwuemekachm merged commit c926e8c into develop Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants