Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HEIF conversion opt-in #347

Open
swissspidy opened this issue Feb 8, 2024 · 4 comments
Open

Make HEIF conversion opt-in #347

swissspidy opened this issue Feb 8, 2024 · 4 comments
Labels
enhancement New feature or request p2

Comments

@swissspidy
Copy link
Owner

Maybe a general toggle such as "Convert incompatible images to web safe formats" and then this can also cover things like TIFF or JPEG 2000 or JPEG XL which don't work in (all) browsers.

Relevant core ticket: https://core.trac.wordpress.org/ticket/53645

@swissspidy
Copy link
Owner Author

swissspidy commented Feb 8, 2024

This could also work like this:

  1. Drop HEIF item into editor
  2. Get presented with a modal that says the image format and is not supported by all browsers. Would you like to convert this to a web safe format?
    • Yes, always convert
    • No, upload as-is, with the downside that there won't be any thumbnails etc. (Only really works in Safari)
    • Cancel upload

@swissspidy
Copy link
Owner Author

Some good considerations over at https://core.trac.wordpress.org/ticket/53645#comment:12

@swissspidy
Copy link
Owner Author

Related: I don't think HEIC warrants an extra setting like this:

Screenshot 2024-05-30 at 16 08 49

Could be much simpler with a "Convert non-web-safe images like HEIC to web-safe format" checkbox, then use the "default image format" value for that.

@swissspidy
Copy link
Owner Author

Aside: this is missing a "default image quality" checkbox

@swissspidy swissspidy added the p2 label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p2
Projects
None yet
Development

No branches or pull requests

1 participant