Core integration notes

[swissspidy]

Working draft for things to take care of when merging into Gutenberg.

Video poster in video block

Update the onFileChange callback (onSelectVideo) to get the video's poster image from the REST API response. Right now it only supports/expects the format returned by the media modal (from wp_prepare_attachment_for_js()).

https://github.com/WordPress/gutenberg/blob/e0a413d213a2a829ece52c6728515b10b0154d8d/packages/block-library/src/video/edit.js#L94

https://github.com/WordPress/gutenberg/blob/e0a413d213a2a829ece52c6728515b10b0154d8d/packages/block-library/src/video/edit.js#L152-L153

The poster URL will be accessible via media._embedded['wp:featuredmedia'][0].source_url as long as media upload (and sideload) happens with ?_embed=wp:featuredmedia

Update callbacks in the upload queue as well:

media-experiments/packages/upload-media/src/store/actions.ts

Lines 1358 to 1365 in e077f63

	// Video block expects such a structure for the poster.
	// https://github.com/WordPress/gutenberg/blob/e0a413d213a2a829ece52c6728515b10b0154d8d/packages/block-library/src/video/edit.js#L154
	const updatedAttachment = {
	...attachment,
	image: {
	src: posterAttachment.url,
	},
	};

Video placeholder

Adapt WordPress/gutenberg#63643 for the video block

Save lock

Partially revert WordPress/gutenberg#41120 as the locking needs to happen before the actual upload