Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider getting rid of default param value in "raw" or at least deserialising it only once #28

Closed
swistakm opened this issue Aug 3, 2016 · 3 comments

Comments

@swistakm
Copy link
Owner

swistakm commented Aug 3, 2016

As noted in #27 PR default values are deserialised and validated every time they are retrieved and this could be obviously improved. Consider getting rid of that limitation or making default value deserialised only once on init.

@swistakm
Copy link
Owner Author

I remove it from 0.3.0 milestone because:

  • in case of changing the default value from "raw" to "native" we will break backwards compatibility so it should land in at least 1.0.0
  • in case of changing param handling to deserialise default value only once it will be simple enhancement that can be done even in patch release

@swistakm swistakm removed this from the 0.3.0 milestone Nov 16, 2016
@tomislater
Copy link
Collaborator

in case of changing param handling to deserialise default value only once it will be simple enhancement that can be done even in patch release

Ok, I have tried to do this, and it makes no sense. The code is not more readable after this change, and the logic is complicated.

@swistakm
Copy link
Owner Author

Ok, let's close it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants