Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phoenix_html 4.0 compatibility #349

Closed
eriknaslund opened this issue Jan 7, 2024 · 2 comments
Closed

phoenix_html 4.0 compatibility #349

eriknaslund opened this issue Jan 7, 2024 · 2 comments

Comments

@eriknaslund
Copy link

The current version of Swoosh (1.2.0) depends on phoenix_html "~> 3.0". Since 4.0 is out now this has started causing some compatibility problems for me, as other libraries are moving to phoenix_html 4.0.

It'd be great to have phoenix_swoosh upgrade the phoenix_html dep to ~> 4.0.
I'd be happy to give the upgrade a shot myself if that's OK?

@princemaple
Copy link
Member

Hi, I've released v1.2.1 that allows phoenix_html ~> 4.0. Feel free to send PR to make additional changes that you see fit. Cheers!

@eriknaslund
Copy link
Author

Thanks a bunch @princemaple for the super-quick fix! I just tried the new release and it works like a charm :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants