Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User's shell not respected, pwd on start is /opt/cool-old-term #16

Closed
terminalmage opened this issue Jul 29, 2014 · 9 comments
Closed

Comments

@terminalmage
Copy link

Installed git HEAD via the AUR PKGBUILD.

It seems like the terminal can't be started by executing the path to cool-old-term, unless you are in the directory in which it resides. This seems to have something to do with how it is launched (via qmlscene).

Also, my shell is not respected, it uses bash no matter what. This is probably due to the fact that /usr/bin/cool-old-term is simply a bash script that changes to /opt/cool-old-term and runs ./cool-old-term

[erik@saltmine cool-old-term]$ ps aux | grep bash
erik     32606  0.0  0.0  13584  3208 ?        Ss   09:26   0:00 /bin/bash /usr/bin/cool-old-term
erik     32607  0.0  0.0  13584  3052 ?        S    09:26   0:00 /bin/bash ./cool-old-term
erik     32613  0.2  0.1  16480  4400 pts/14   Ss   09:26   0:00 /bin/bash
erik     32628  0.0  0.0  10712  2268 pts/14   S+   09:26   0:00 grep bash
[erik@saltmine cool-old-term]$ 
@terminalmage
Copy link
Author

Nope, I changed both /opt/bin/cool-old-term and /usr/bin/cool-old-term so that they used zsh in the shebang line, and it still uses bash.

@Swordfish90
Copy link
Owner

Thank you. Those are definitely problems with my dummy launch script. I will look into it...

@terminalmage
Copy link
Author

No prob!

@Swordfish90
Copy link
Owner

Ok it looks /bin/bash is hard coded when the plugin is launched... I will fix that soon...

@NicolasCARPi
Copy link

Yes, zsh user here. +1 :D

@Swordfish90
Copy link
Owner

I just pushed a new branch which should fix those two issues. Please try that and let me know, so I can close the issue and merge the branch into master. https://github.com/Swordifish90/cool-old-term/tree/shellssupport

@NicolasCARPi
Copy link

Hello,
I tried your branch.
It works \o/
Thanks :)

@Swordfish90
Copy link
Owner

Very good!... Closing the issue...

@terminalmage
Copy link
Author

Awesome! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants