Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate profile names are confusing. #27

Closed
edam opened this issue Jul 29, 2014 · 1 comment
Closed

Duplicate profile names are confusing. #27

edam opened this issue Jul 29, 2014 · 1 comment

Comments

@edam
Copy link

edam commented Jul 29, 2014

It is possible to create two profiles with the same name, simply by saving your settings again with the same name. This is pretty confusing. I suppose I assumed that saving to a profile with the same name would overwrite the previous settings. (It wasn't until I realised there was more than one profile with the same name in the drop-down list that I understood why reloading the profile reset everything to the previous save!)

I can think of two solutions to this: you could prevent the user from saving when the name they have chosen for the profile already exists. (There's nothing to stop them deleting the existing profile first and saving again.) Or, you could overwrite any existing profile with the same name. (This would seem to be the less bothersome solution, from the user's perspective.)

@Swordfish90
Copy link
Owner

Also this has been fixed. I also forgot to check against empty names. Now everything should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants