Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't support new Global Site Tag (gtag.js) tracking #3

Closed
studio-blueboat opened this issue Feb 27, 2020 · 4 comments
Closed

Doesn't support new Global Site Tag (gtag.js) tracking #3

studio-blueboat opened this issue Feb 27, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@studio-blueboat
Copy link

The new recommended google analytics tracking code uses a different syntax.

We've update our site manually to run the following on transition complete:

gtag('config', '<TRACKING CODE>', {
	'page_title' : document.title,
	'page_path': window.location.pathname + window.location.search
});

I would suggest an update that checks for the presence of either configuration for backwards compatibility.

Do you accept PRs?

@gmrchk
Copy link
Member

gmrchk commented Mar 1, 2020

Hi, this has been already discussed once over here.

PR would be awesome.

@ajmnz
Copy link

ajmnz commented Apr 8, 2020

I found this plugin from Joshua Hallee that seems to do the job. Would be nice to have it officially included in the GA Plugin.

@gmrchk gmrchk added the enhancement New feature or request label Jun 7, 2020
@gmrchk
Copy link
Member

gmrchk commented Jun 7, 2020

Noice! I actually like that @joshuaHallee took the time to create the plugin. It's also nice it's specialized instead of having a bunch of IFs in it.
I will contact him about including the plugin in the swup docs or moving it under swup org. all together.

@gmrchk
Copy link
Member

gmrchk commented Jun 29, 2020

Unfortunately, no email listed, but I'm guessing @joshuaHallee doesn't mind since it's a public repo. Listed in docs.

@gmrchk gmrchk closed this as completed Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants