Refactor how the ClientServer works
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ClientServer` object no longer automatically initializes or shutdown the LSP session. It *does* however, still start and stop the client/server pair. In fact, the `ClientServer` object shouldn't rely on anything LSP specific, which should open the door to using `pytest_lsp` to test any JSON-RPC based protocol in the future. This means that fixture functions annotated with the `@pytest_lsp.fixture` decorator are now responsible for initializing and shutting down the LSP session, also granting the test author greater control over the initial setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ClientServerobject no longer automatically initializes or shutsdown the LSP session. It does however, still start and stop the client/server pair.In fact, the
ClientServerobject shouldn't rely on anything LSP specific, which should open the door to usingpytest_lspto test any JSON-RPC based protocol in the future.This means that fixture functions annotated with the
@pytest_lsp.fixturedecorator are now responsible for initializing and shutting down the LSP session, also granting the test author greater control over the initial setup.