Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate extents when creating a Mesh #2652

Open
1 of 4 tasks
nilsvu opened this issue Dec 14, 2020 · 0 comments
Open
1 of 4 tasks

Validate extents when creating a Mesh #2652

nilsvu opened this issue Dec 14, 2020 · 0 comments

Comments

@nilsvu
Copy link
Member

nilsvu commented Dec 14, 2020

Feature request:

Mesh currently accepts any extents, i.e. number of points per dimension. However, each combination of spectral basis and quadrature has a minimum and maximum number of grid points. For example, any mesh with "GaussLobatto" quadrature must have at least two points (on the faces of the element). We should check this requirement when the mesh ist constructed, in particular when it is constructed from input-file options to give the user a helpful error message.

To implement this feature we need the following:

  • Two functions in the Spectral namespace that take a Spectral::Basis and a Spectral::Quadrature at runtime and return the minimum and maximum number of grid points, respectively (in addition to the existing functions that are evaluated at compile-time).
  • Logic in the Mesh constructors that validate the extents and give useful error messages.

Component:

  • Code
  • Documentation
  • Build system
  • Continuous integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant