Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement zoxide as a built-in plugin #865

Closed
1 task done
sxyazi opened this issue Apr 2, 2024 · 2 comments · Fixed by #881
Closed
1 task done

Re-implement zoxide as a built-in plugin #865

sxyazi opened this issue Apr 2, 2024 · 2 comments · Fixed by #881
Labels
feature New feature request good first issue Good for newcomers

Comments

@sxyazi
Copy link
Owner

sxyazi commented Apr 2, 2024

Please describe the problem you're trying to solve

The Zoxide implementation in Yazi has had some long-standing issues, and this FR attempts to address them:

  • Resolves how to use Multi-Tab & fzf, zoxide #859 - @fastfading: The new Zoxide implementation will detect if the user is using Zoxide for the first time (i.e., just installed Zoxide). At this point, since the Zoxide database is empty, an error will occur. The plugin should check for this error and send an error notification to the user via ya.notify().

  • Resolves jump zoxide appears to be broken #310 - @LeXofLeviafan: Reasons are the same as above.

  • Resolves Update zoxide DB from browsing #860 - @fdw: The new plugin will be able to add the directories the user browses to the zoxide database by providing the ability to further configure it in the user's init.lua, i.e. add this require("zoxide"):setup { update_db = true } to the init.lua file.

  • Resolves Support for zsh-z #757 - @hacker-DOM: By implementing Zoxide as a plugin, provide an example of integrating such external tools. When users need other tools besides Zoxide, they can easily copy the preset code and make some minor modifications to achieve their goals. Here, it is modifying zoxide to zsh-z command.

  • Resolves feat: add a way to use zoxide as an input field #654 - @diniamo: This FR will allow users to simply modify Lua to customize their workflow without needing to add code to Yazi codebase. This can help reduce my maintenance costs while avoiding Yazi bloat, as adding these specific workflows would require adding more configuration options to control different behaviors of the same functionality. This is also a barrier for new users getting started with Yazi configuration, as they would need to learn various configuration options and understand the subtle differences between each, which goes against Yazi's goal of providing a simple user experience.


Done by #881

Would you be willing to contribute this feature?

  • Yes, I'll give it a shot

Describe the solution you'd like

See above

Additional context

No response

@sxyazi sxyazi added the feature New feature request label Apr 2, 2024
@sxyazi
Copy link
Owner Author

sxyazi commented Apr 2, 2024

If anyone is interested in implementing it, please reply to this issue

Copy link

github-actions bot commented May 7, 2024

I'm going to lock this issue because it has been closed for 30 days. ⏳
This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant