feat: support BinaryExpression

unplugin · Jun 18, 2022 · fac1e3f · fac1e3f
1 parent c139052
commit fac1e3f
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 8 deletions.
diff --git a/src/core/convert.ts b/src/core/convert.ts
@@ -31,6 +31,7 @@ import type {
   JSXText,
   Literal,
   Node,
+  PrivateName,
   TemplateLiteral,
 } from '@babel/types'
 
@@ -214,7 +215,9 @@ export const convert = (code: string, debug?: boolean) => {
     return value
   }
 
-  function expressionToString(node: Expression | JSXEmptyExpression) {
+  function expressionToString(
+    node: Expression | JSXEmptyExpression | PrivateName
+  ): string {
     if (isLiteral(node)) {
       return literalToString(node)
     } else if (isJSX(node)) {
@@ -223,9 +226,11 @@ export const convert = (code: string, debug?: boolean) => {
 
     switch (node.type) {
       case 'ArrayExpression':
-      case 'ObjectExpression': {
+      case 'ObjectExpression':
         return normalizeObjectString(getSource(node))
-      }
+
+      case 'BinaryExpression':
+        return expressionToString(node.left) + expressionToString(node.right)
 
       default:
         return notSupported(node)

diff --git a/tests/convert.test.tsx b/tests/convert.test.tsx
@@ -137,6 +137,15 @@ describe('convert', () => {
     )
   })
 
+  test('BinaryExpression', () => {
+    // eslint-disable-next-line prefer-template
+    expect(jsxToString(<>{`a` + 1 + 'b'}</>)).toMatchInlineSnapshot('"a1b"')
+    // eslint-disable-next-line prefer-template
+    expect(jsxToString(<>{`a` + true + false + 'b'}</>)).toMatchInlineSnapshot(
+      '"ab"'
+    )
+  })
+
   describe('error', () => {
     test('without function', () => {
       expect(() => <div />).toThrowError()
@@ -160,11 +169,6 @@ describe('convert', () => {
       ).toThrowErrorMatchingInlineSnapshot(
         '"Error: not supported Identifier: n"'
       )
-      expect(() =>
-        jsxToString(<div id={'a' + 'b'} />)
-      ).toThrowErrorMatchingInlineSnapshot(
-        "\"Error: not supported BinaryExpression: 'a' + 'b'\""
-      )
       expect(() =>
         jsxToString(<div tabIndex={n++} />)
       ).toThrowErrorMatchingInlineSnapshot(