Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with WPML #61

Open
vukvukovich opened this issue Mar 20, 2015 · 13 comments
Open

Bug with WPML #61

vukvukovich opened this issue Mar 20, 2015 · 13 comments

Comments

@vukvukovich
Copy link

There is the problem when "domain per language" option is selected in WPML.

ex. domain.local and en.domain.local.

In that case function is returning "false".

@amitkvint
Copy link

Is there any chance you could look into that? We can help if needed.

@senlin
Copy link

senlin commented Aug 11, 2015

tbh this doesn't make much sense
@vukvukovich as your issue is of almost 6 months ago, care to explain, does it still exist?

@vukvukovich
Copy link
Author

@senlin Issue is still present, but it is caused by a bug in WPML.

The problem is because of not handling wp_upload_dir() & content_url() functions.

@senlin
Copy link

senlin commented Aug 24, 2015

@vukvukovich Have you opened a bug report with WPML? Usually they are very cooperative when you file a report with detailed information so they can reproduce the issue.

@amitkvint
Copy link

@senlin - @vukvukovich is a WPML developer. He is referring to an inner ticket we have waiting to be fixed for one of our next WPML releases.

@senlin
Copy link

senlin commented Aug 24, 2015

@webifish thanks for the disclosure :) As WPML just released new versions, may I ask for which version this bug is scheduled to be squashed?

@vukvukovich
Copy link
Author

It could be in next major one.

@senlin
Copy link

senlin commented Aug 24, 2015

It could be in next major one.

I'm sorry, but that really is a super vague answer. You'd better say "I have no idea if it will ever be addressed; don't count on it", so we can move on...

@vukvukovich
Copy link
Author

Sorry, but I cannot give you precise answer at the moment. It will be definitely fixed. I will update here as soon as I have more precise information.

@senlin
Copy link

senlin commented Aug 24, 2015

ok thanks @vukvukovich

@ghost
Copy link

ghost commented Oct 21, 2015

This patch works with Domain per language setting. In aq_resizer-1x.php add following lines at the beginning of sf_aq_resize function.

/* WPML Fix for Image issue in Different domain per language */
if ( defined( 'ICL_SITEPRESS_VERSION' )){
global $sitepress;
$url = $sitepress->convert_url($url,$sitepress->get_default_language());
}
/* WPML Fix for Image issue in Different domain per language */

@ghost
Copy link

ghost commented Dec 16, 2015

@syamilmj Can you please confirm, if the code works for you, If yes, can you please add it in aq_resizer-1x.php file, So its compatible with WPML.

As we got the client back, after updating the theme, which has resizer plugin installed, The new updates didn't work, May be the code is not added yet.

@alessandroalessio
Copy link

alessandroalessio commented Aug 3, 2020

Add my personal 50 cents to notify this bugifx not working if the website use WPML but not in "domain mode".
I've added a row to completely solve my problem:

/* WPML Fix */ $wpml_icl_settings = get_option('icl_sitepress_settings'); if ( defined( 'ICL_SITEPRESS_VERSION' ) && $wpml_icl_settings['language_negotiation_type']==2 ){ global $sitepress; $url = $sitepress->convert_url( $url, $sitepress->get_default_language() ); var_dump($url); } /* WPML Fix */

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants