Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar description #57

Closed
apacha opened this issue Aug 5, 2022 · 3 comments · Fixed by #60
Closed

Progress bar description #57

apacha opened this issue Aug 5, 2022 · 3 comments · Fixed by #60
Assignees
Labels
enhancement New feature or request

Comments

@apacha
Copy link

apacha commented Aug 5, 2022

MPIRE uses TQDM as a progress-bar, which is very nice. However, it would be great if there was the possibility to somehow control the progress-bar with the parameters that are available, e.g., the description. We have several progress bars in our app and it would be nice to see not only that something is happening, but also what is happening.

Do you think that would be a possible expansion of MPIRE? Is there another way how you can configure TQDM? If yes, where can I find this information in the documentation?

@sybrenjansen
Copy link
Owner

I can add a progress_bar_options parameter to the map functions that is then passed on to the tqdm progress bar upon creation. As the progress bar lives in another thread and is not accessible, live updates to the description would require quite the overhaul.

Would this approach be acceptable for your usecase?

@apacha
Copy link
Author

apacha commented Aug 15, 2022

Having a single progress_bar_options parameter would be absolutely sufficient, as most options like the description or the smoothing only needs to be set once while creating the progress bar anyway.

@sybrenjansen sybrenjansen self-assigned this Aug 15, 2022
@sybrenjansen sybrenjansen added the enhancement New feature or request label Aug 15, 2022
@sybrenjansen sybrenjansen mentioned this issue Aug 17, 2022
@sybrenjansen
Copy link
Owner

Added to v2.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants