Test macOS #92
Test macOS #92
Conversation
|
The |
|
Until I have a mac I cannot test this, unfortunately. I will try to set up a VM in the near future, but I've been quite busy 😅 I can live with the hacky This PR will at least fix a few things already for mac. Probably enough for people to get started. And when I get time to test it on mac we can add macos properly. |
.github/workflows/python-package.yml
Outdated
| @@ -15,7 +15,7 @@ jobs: | |||
| runs-on: ${{ matrix.os }} | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-20.04, windows-latest] | |||
| os: [ubuntu-20.04, windows-latest, macos-11] | |||
There was a problem hiding this comment.
Let's remove this for now, until everything is properly tested
mpire/comms.py
Outdated
| @@ -635,6 +639,8 @@ def drain_results_queue_terminate_worker(self, dont_wait_event: threading.Event) | |||
| except (queue.Empty, OSError): | |||
| if got_results: | |||
| dont_wait_event.set() | |||
| # Force collection of semaphore objects | |||
| gc.collect() | |||
There was a problem hiding this comment.
Add TODO that this still needs a proper fix, same for the other gc.collect
There was a problem hiding this comment.
One minor things left. Can you add a line to docs/changelog.rst with the changes you made? E.g., added a workaround for semaphore leakage on macOs + fixed a bug when working in a fork context while the system default is spawn.
You can put it under the unreleased section.
No description provided.