Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google SERP Description widths changed again. #318

Closed
sybrew opened this issue May 23, 2018 · 2 comments
Closed

Google SERP Description widths changed again. #318

sybrew opened this issue May 23, 2018 · 2 comments
Assignees
@sybrew
Labels
[Priority] Critical Issues like these should stop all work elsewhere, and a patch should be sent out the ASAP. [Status] Feedback required [Status] Requires testing
Milestone
3.1.0

Comments

@sybrew
Copy link
Owner

sybrew commented May 23, 2018 •
edited

Previous: #231

Not all sites (or even pages) are affected.
See: https://twitter.com/dannysullivan/status/996065145443893249

More information will be added as soon as I find out more...

As a (permanent) resolution to accompany this, I'm going to add a three-color-scheme to the pixel counter bar.

  1. Green: Will definitely fit.
  2. Yellow: Might be truncated (on mobile).
  3. Red: Will definitely be truncated.

Color vision deficiency support is necessary. This might even be in the form of shifting backgrounds.
@sybrew sybrew added [Status] Feedback required [Status] Requires testing [Priority] Critical Issues like these should stop all work elsewhere, and a patch should be sent out the ASAP. labels May 23, 2018
@sybrew sybrew self-assigned this May 23, 2018
@sybrew
Copy link
Owner Author

sybrew commented Jun 9, 2018

From lilgames' concern:
We should also test the pixel counter's accuracy on different browsers.
Especially in dealing with Retina, HD, 4K, Windows, OSX, zoom levels, DPI settings, browsers, etc.

I didn't notice inconsistencies with the small sample I just went through.

@sybrew
Copy link
Owner Author

sybrew commented Jun 30, 2018

Related: #227

@sybrew sybrew added this to the 3.1.0 milestone Jul 17, 2018
@sybrew sybrew closed this as completed in fe341d5 Aug 23, 2018
@sybrew sybrew mentioned this issue May 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sybrew sybrew

Labels
[Priority] Critical Issues like these should stop all work elsewhere, and a patch should be sent out the ASAP. [Status] Feedback required [Status] Requires testing
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
1 participant
@sybrew