Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds msgGasLimit as param when requesting fee from fee oracle service #136

Merged
merged 5 commits into from
Jan 12, 2023
Merged

feat: Adds msgGasLimit as param when requesting fee from fee oracle service #136

merged 5 commits into from
Jan 12, 2023

Conversation

wainola
Copy link
Contributor

@wainola wainola commented Jan 9, 2023

Description

Related Issue Or Context

Closes: #131

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@wainola wainola changed the title Adds msgGasLimit as param when requesting fee from fee oracle service feat: Adds msgGasLimit as param when requesting fee from fee oracle service Jan 9, 2023
@wainola wainola marked this pull request as ready for review January 10, 2023 03:22
@wainola wainola requested a review from enemycnt January 10, 2023 03:22
@wainola wainola merged commit 449b5fa into main Jan 12, 2023
@wainola wainola deleted the feat/gas-limit-feeOracle branch January 12, 2023 12:44
@github-actions github-actions bot mentioned this pull request Jan 12, 2023
Merged
@enemycnt enemycnt mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enemycnt enemycnt enemycnt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include gas limit in FeeOracle data
2 participants
@wainola @enemycnt