Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update deposit method to support substrate addresses #189

Merged
merged 8 commits into from
Mar 13, 2023
Merged

feat: Update deposit method to support substrate addresses #189

merged 8 commits into from
Mar 13, 2023

Conversation

enemycnt
Copy link
Contributor

@enemycnt enemycnt commented Mar 8, 2023 •
edited
Loading

Deposit and fee functions are updated to use addresses of variable size
SDK package type is rollbacked to commonjs. Module build will be enabled in #183

Description

Related Issue Or Context

Closes: #186

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@enemycnt enemycnt changed the title Update deposit method to support substrate addresses feat: Update deposit method to support substrate addresses Mar 8, 2023
@enemycnt enemycnt marked this pull request as ready for review March 8, 2023 22:17
@enemycnt enemycnt requested a review from wainola March 8, 2023 22:18
wainola
wainola requested changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@wainola wainola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix eslint CI messages

@enemycnt enemycnt requested a review from wainola March 9, 2023 15:39
wainola
wainola previously approved these changes Mar 9, 2023
View reviewed changes
@wainola wainola requested a review from BeroBurny March 9, 2023 16:04
@enemycnt enemycnt requested a review from wainola March 13, 2023 15:24
@wainola wainola merged commit a569165 into main Mar 13, 2023
@wainola wainola deleted the feat/substrate-address branch March 13, 2023 16:08
@mpetrun5 mpetrun5 mentioned this pull request Mar 13, 2023
Merged
@enemycnt enemycnt mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeroBurny BeroBurny BeroBurny approved these changes

@wainola wainola wainola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update deposit method to support substrate addresses
3 participants
@enemycnt @BeroBurny @wainola