Adds strings localization #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why did those images got replaced? |
Generated by 🚫 Danger |
|
Uh, I forgot to mention it! I move all app Resources (assets catalog, splash screen story board and configuration plist) into Resources group - It makes the project structure cleaner. It also looks like Travis is failing again for some reason.. o.O |
|
No idea, why travis is failing those build logs are sometimes hell... |
|
This is really weird, it works just fine on my laptop.. |
|
Cool, it works with new Xcode, I will squash the CI commits and it's ready to merge. |
Require Xcode 9.1 on Travis
josefdolezal
force-pushed
the
jdo/localizations
branch
from
2efca7f
to
3b03d6e
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces CZ/EN localization discussed in #22. All hardcoded strings are now replaced with localized strings based on user's phone preferences.
Localization string keys are converted to name-spaced enum to ensure compile-time check of strings validity. The enums are generated with SwiftGen using aggregated Xcode target.
I have also added Danger action, which checks whether both languages are updated together.
✅ The README is updated.