Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License issues #4

Closed
hroncok opened this issue Jun 1, 2016 · 13 comments · Fixed by #19
Closed

License issues #4

hroncok opened this issue Jun 1, 2016 · 13 comments · Fixed by #19

Comments

@hroncok
Copy link
Contributor

hroncok commented Jun 1, 2016

This repo has no license information, making it in fact legally not redistributable.

Also, when redistributing the binary form, I'm quite confident you do not follow licenses of used libraries, making it in fact illegal.

@hroncok
Copy link
Contributor Author

hroncok commented Jun 1, 2016

@syky27
Copy link
Owner

syky27 commented Jun 1, 2016

I know that I don't respect licences yet.

It is on todo list, maybe you could add it in this repo I will place note inside the actual app.

@hroncok
Copy link
Contributor Author

hroncok commented Jun 1, 2016

No need to place this in the repo, the repo is redistribution in source form where you include upstream license files.

@hroncok
Copy link
Contributor Author

hroncok commented Jun 1, 2016

Except maybe https://github.com/syky27/lunch_guy-ios/tree/dev/Pods/Crashlytics where I don't see it at all.

@syky27
Copy link
Owner

syky27 commented Oct 26, 2017

I would integrate this https://github.com/AJTY/ESOpenSourceLicensesKit

@josefdolezal
Copy link
Contributor

Is it really necessary to include licenses inside the app? I quickly checked Kickstarter app and GitHawk. Both of these apps use Alamofire but without any explicit notice.

@hroncok
Copy link
Contributor Author

hroncok commented Oct 27, 2017

Only a lawyer can answer that question.

@syky27
Copy link
Owner

syky27 commented Oct 27, 2017 via email

@hroncok
Copy link
Contributor Author

hroncok commented Oct 27, 2017

It might be only for non open source apps

There is no such rule. If you distribute someone else's software, you have to comply with the license terms. The license terms are usually pretty clear:

Copyright (c) 2014-2017 Alamofire Software Foundation (http://alamofire.org/)

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.

@josefdolezal
Copy link
Contributor

I checked again the GitHawk app I mentioned earlier and found out that they have Acknowledgements section with list of all licenses in iOS settings. Seems like a good solution to me.

group 2x

@syky27
Copy link
Owner

syky27 commented Oct 28, 2017 via email

@josefdolezal
Copy link
Contributor

Cool then, if you haven't started yet, I can create PR for this one. There is already a homebrew tool which generates plists from Pods directory. So we can setup CI and Xcode target to automate this.

@syky27
Copy link
Owner

syky27 commented Oct 29, 2017

Go ahead, I got tons of other work, which is more pressing for me now... :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants