You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For some (obscure) reasons, the DateTimeInterface is missing some methods, such as add()modify(). And since the current implementation is only returning DateTimeImmutable, I think we should typehint it to that, so StaticAnalysis tools will stop complaining.
The text was updated successfully, but these errors were encountered:
the reason is not obscure actually: DateTime::add and DateTimeImmutable::add cannot be used in the same way transparently (with DateTime::add, the current object is mutated, so your code might be ignoring the return value)
For some (obscure) reasons, the DateTimeInterface is missing some methods, such as
add()
modify()
. And since the current implementation is only returning DateTimeImmutable, I think we should typehint it to that, so StaticAnalysis tools will stop complaining.The text was updated successfully, but these errors were encountered: