Careful enabling order sof-deleting

[cnoa23]

Hi, following good practice from contributors i enabled sof-deleting for order entity. Now when i add a new order "Place Order" it fail because constrain in data base.
Order has field order_number and it is unique, it is generated by OrderNumberGenerator in SalesBundle/Generator.

While it generate the number it call getLastOrderNumber that use findBy and is enable sof-deleting so it generate existing order number.

To solve this in Order Repository on CoreBundle y create method to return last order but now softdeleting is disable, and change on classs OrderNumberGenerator method getLastOrderNumber to use my new method.

I hope this help you, and please suggest other solution more elegant.
Thanks
Carlos.

//Sylius\Bundle\SalesBundle\Generator
 protected function getLastOrderNumber()
    {
       // $lastOrder = current($this->repository->findBy(array(), array('createdAt' => 'desc'), 1));
       $lastOrder = current($this->repository->findLast(1));

        if (!$lastOrder) {
            return str_repeat('0', $this->numberLength);
        }

        return $lastOrder->getNumber();
    }

//namespace Sylius\Bundle\CoreBundle\Repository;
    public function findLast($limit = 1)
    {       
        $em = $this->getEntityManager();
        $filter = $em->getFilters()->disable('softdeleteable');
        $filter->disableForEntity('SyliusCoreBundle\Order');
        $lastOrder = $this->findBy(array(), array('createdAt' => 'desc'), $limit);
        $filter->enableForEntity('SyliusCoreBundle\Order');

        return $lastOrder;
}

[sargath]

Yes i think this a still real problem, not only for a order but, for taxonomies and goods too.

[pjedrzejewski]

Thanks for the heads up, this one is old, but useful! :)