[Enhancement] Consider removing all sylius_ database tables prefix

[marcospassos]

Once there is no way (at least a simple way) to override the DB's tables/repositories names, I think the sylius_ prefix should be removed. If a prefix is desirable, it can be solved using a listener that can be disabled.

[winzou]

👎 prefixes keep sylius logic separated from the main app logic (in the db I mean).

[marcospassos]

I think it should be an option, not a requirement. As I said, it's can be done through Doctrine's events, giving us both options. In the current way you have just one option.

[winzou]

Do you think about http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/cookbook/sql-table-prefixes.html ?
If so, is there a mean to prefix only a bunch of tables (I think of only the sylius ones)? It would be a good solution.

[marcospassos]

Exactly. We can restrict the prefix only to Sylius tables, through namespace. So we can add a config option to allow prefix customization. It's a flexible and customizable solution, that allows enable/disable when desirable.

sylius:
    table_prefix: sylius_

[winzou]

👍 :)

[pjedrzejewski]

I do not see big harm in prefixes, but if we can make them optional - +1, if we make them configurable - +2!

[pjedrzejewski]

But I don't think we should remove them by default, I find it good practice, I clearly see what is part of custom app, and what is coming from Sylius, just like @winzou said!

[marcospassos]

Yes, this is my intention.

[smalot]

👍

[elliot]

Closable by #447 ?