Bug: Discourse Category Banners theme component conflict

[AndyatFocallocal]

The Discourse Category Banners theme component is conflicting with Docuss and preventing users from scrolling down to the bottom of a category

I've turned it off for now, here's the direct link to adding in our admin section.

Here's it's page in meta, which is where you'll find its Github

Here is a category in our site where it is set up when turned on, so you can test it.

[sylque]

The Category Banners component inserts a div below the Discourse header, using the below-site-header-outlet. The issue is that Docuss considers this outlet as part of the Discourse header (i.e. displays it in full width). But because the header is not 60 pixels in height anymore, the padding-top of #dcs-row is wrong.

Do developers using the below-site-header-outlet consider their component to be part of the header or part of the page? It probably depends on their use case. In the case of the Category Banners component, the banner is clearly part of the page (because it changes for every category).

So what I'll do is to include below-site-header-outlet to #dcs-right. This is an easy way to fix the problem. We'll see later if this causes incompatibility with other plugins.

[sylque]

Fixed in 1.0.9.
@AndyatFocallocal , please update the plugin and confirm that it works as expected.

[sylque]

Regression: popups are now cut in half on the right of the screen.

[sylque]

Fixed in dcs-discourse-plugin2 version 1.0.10.
@AndyatFocallocal, please update the plugin and confirm that Discourse Category Banners works as expected.