Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with \, and ~ #160

Closed
pkel opened this issue Dec 8, 2020 · 4 comments · Fixed by #192
Closed

Problems with \, and ~ #160

pkel opened this issue Dec 8, 2020 · 4 comments · Fixed by #192
Labels
bug Something isn't working
Milestone

Comments

@pkel
Copy link

pkel commented Dec 8, 2020

Thanks for your great work. Textidote is a relief.

I ran into problems when using ~ and \, like in the following example.

\documentclass{article}
 
\begin{document}
I want to demo a small textidote bug regarding white space. It seems that \verb|\,| and \verb|~| are not recognized as such, e.\,g.~this should be fine.
 
It shows up when I cite Someone et al.~\cite{someone2020} or add a small space between a number and a unit as in 100\,\%. By the way, I think this last sentence is parsed as comment.
\end{document}

Do you consider this a bug or should I adapt?

I'm running textidote v0.8.1 from the jar file provided on the release page.

@sylvainhalle sylvainhalle added the bug Something isn't working label Dec 10, 2020
@sylvainhalle sylvainhalle added this to the v0.8.2 milestone Dec 10, 2020
@sylvainhalle
Copy link
Owner

Thanks for your post. This could easily be added to the next version (note to myself: replace both symbols into spaces at the cleaning step).

@ErikBjare
Copy link
Contributor

Not sure if this is as intended (so holding off on creating an issue), but I get warnings for blablabla Fucci et al.~\cite{fucci_2019} blablabla. Isn't this best-practice?

@sylvainhalle
Copy link
Owner

Could be handled by changing this line:

sh:010 et al\.[^\\,] Use a backslash or comma after the period; otherwise LaTeX will think it is a full stop ending a sentence.

replace [^\\,] by [^\\,~].

@ErikBjare
Copy link
Contributor

@sylvainhalle Thanks for the quick reply! PR submitted in #192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants