New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workaround for bug #28

Closed

sylveon opened this issue Sep 10, 2020 · 0 comments

Labels

bug enhancement

Owner

sylveon commented Sep 10, 2020

There currently is a workaround for microsoft/STL#1183 here:

member_thunk/include/member_thunk/details/thunk/thunk.impl.x64.hpp

Lines 22 to 24 in 83057fc

    
           		// TODO: uncomment when https://github.com/microsoft/STL/wiki/Changelog#expected-in-vs-2019-168-preview-3 ships 
        
           #pragma warning(suppress: 4244) 
        
           		std::fill(reinterpret_cast<volatile std::uint8_t*>(this), reinterpret_cast<volatile std::uint8_t*>(this + 1), /*static_cast<std::uint8_t>*/(0xCC));

It should be removed when possible

sylveon added enhancement bug labels

sylveon closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment