Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate ENV variables for reading PATH to credential JSON file #1

Open
khusnetdinov opened this issue Jan 13, 2019 · 0 comments
Open

Integrate ENV variables for reading PATH to credential JSON file #1

khusnetdinov opened this issue Jan 13, 2019 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@khusnetdinov
Copy link
Member

khusnetdinov commented Jan 13, 2019 •
edited

Given:
Google Translate class gets the path to JSON file via hardcoded string 'env.json'
https://github.com/symbiod/localizator/blob/master/lib/localizator/translation.rb#L11

Need:

  • Pass path to JSON file via 'ENV['CREDENTIALS']'
  • Create .env.example file with empty variable
  • Add to gitignore .env file, that is used for local developemnt
  • Update CHANGELOG.md
@khusnetdinov khusnetdinov added help wanted Extra attention is needed good first issue Good for newcomers labels Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@khusnetdinov