-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SS4 version #22
Comments
+1 would be great if a current state was tagged and SS4 compat version rolled :) |
That would be warmly welcomed @SimoTod, as there currently aren't any plans to upgrade this to SS4. Please send through the PR when it's ready! In regards to an SS3 release, there's already a tag (3.1.4) on the tip of master which can be seen here https://github.com/symbiote/silverstripe-sesmail/releases. Would I happen to be missing something? Edit: it looks like the branch alias is incorrect, I'll fix that up. |
Thanks @nglasl. I probably missed the tag last night (I was checking from my mobile). |
@SimoTod did you get anywhere with your PR? I couldn't see a fork with the work started but I'm happy to start this upgrade next week if it hasn't been started elsewhere. |
Hi @wilr , I haven't started yet. I was planning to use it in a project I was working on but I ended up using a different solution. I'm going to be a bit busy in the next few weeks and I won't be able to work on it before mid April so feel free to fork it. 👍 |
@wilr has a version to test at https://github.com/wilr/silverstripe-sesmail.git perhaps we raise a PR and work through peer review on this? |
Sounds good to me :) |
PR at #23 |
The SS4 upgrade has now been merged, thanks for your hard work here @wilr! |
Hi,
Are you okay with me sending a PR to convert the package to SS4?
Unfortunately you never tagged a release so it might break some of the old SS3.
If it's not okay, feel free to close this issue and I'll fork the package with my account and add it to packagist.
Thanks,
Simone
The text was updated successfully, but these errors were encountered: