Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle relative imports in volume better #138

Open
CJ-Wright-Citadel opened this issue Jul 20, 2021 · 0 comments
Open

Handle relative imports in volume better #138

CJ-Wright-Citadel opened this issue Jul 20, 2021 · 0 comments

Comments

@CJ-Wright-Citadel
Copy link
Contributor

We missed a symbol in this audit: symbol-management/api-match-audit@86803ad#diff-1862b12bad147ad174efa035edb162707e3da82a6c825a11122bff1819c069cfR58

Which is coming from https://github.com/ARM-DOE/ACT/blob/v0.7.2/act/plotting/TimeSeriesDisplay.py

I think the issue is that the initial assignment of symbols via shadow in the per module parse has a miss on the shadows dict.

On approach would be:

  1. we know that all symbols in the volume must either be also in that volume or be exposed as part of the surface area of the module.
  2. We can then see which symbols do not have a matching pair and try to re-point them towards existing symbols. In this case we can see that the volume symbol (utils.data_utils...) is close to the exposed symbol plotting.data_utils...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant