Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.0.0 totally breaks even trivial applications. #169

Closed
aadrian opened this issue Aug 5, 2018 · 8 comments
Closed

Version 3.0.0 totally breaks even trivial applications. #169

aadrian opened this issue Aug 5, 2018 · 8 comments

Comments

@aadrian
Copy link

aadrian commented Aug 5, 2018

grails-audit-logging-plugin version 3.0.0 seems to totally break even trivial Grails 3.3.5 applications :( .

Please see in this small example: https://github.com/aadrian/grenderingz/tree/audit_logging

After adding the plug-in, nothing works anymore aadrian/grenderingz@44eb326 :( .

Following the documentation and how this version of the plug-in it's supposed to be different from version 2.x, those are the only changes made that are visible in that commit diff.

Am I missing something? Or is the plug-in indeed broken with Grails 3.3.5?

Thank you.

@robertoschwald
Copy link
Member

I don't know whats your problem, as you didn't state it. Here, your example runs...?

[grenderingz master]$ gradle clean
gradlew: Permission denied
gradlew: cannot execute: Undefined error: 0
[grenderingz master]$ chmod 755 gradlew
[grenderingz master*]$ chmod 755 grailsw
[grenderingz master*]$ grails run-app
Using grailsw
| Resolving Dependencies. Please wait...
Download https://repo.grails.org/grails/core/org/grails/plugins/views-gradle/1.2.8/views-gradle-1.2.8.pom
Download https://repo.grails.org/grails/core/org/grails/plugins/views-gradle/1.2.8/views-gradle-1.2.8.jar
Download https://repo.grails.org/grails/core/org/grails/plugins/views-json/1.2.8/views-json-1.2.8.pom
Download https://repo.grails.org/grails/core/org/grails/views-core/1.2.8/views-core-1.2.8.pom
Download https://repo.grails.org/grails/core/org/grails/plugins/views-json/1.2.8/views-json-1.2.8.jar
Download https://repo.grails.org/grails/core/org/grails/views-core/1.2.8/views-core-1.2.8.jar

CONFIGURE SUCCESSFUL

| Running application...
--> Init application ....
-->  ... Initializing data, since the DB was empty ...
--> Init application DONE!
Grails application running at http://localhost:8080 in environment: development

@robertoschwald
Copy link
Member

Ah, I see. In your example, audit-logging is not included at all.

@robertoschwald
Copy link
Member

Found it. We have springsec plugin dependency as provided in the plugin classpath to be able to compile the SpringSecurityRequestResolver. It seems this is enough that the ControllerMixin gets compiled into the Controller class.

@aadrian
Copy link
Author

aadrian commented Aug 7, 2018

Ah, I see. In your example, audit-logging is not included at all.

https://github.com/aadrian/grenderingz/blob/audit_logging/build.gradle#L64

As I described, the branch audit_logging has the audit logging code.

@longwa
Copy link
Collaborator

longwa commented Aug 7, 2018

I’ll take a look. We are using the plugin in a very large 3.3.6 application with dozens of audited domains and dependencies.

@longwa
Copy link
Collaborator

longwa commented Aug 7, 2018

The https://github.com/robertoschwald/grails-audit-logging-plugin/pull/170 should fix this issue. I used the sample app in this ticket to verify the changes.

@robertoschwald
Copy link
Member

Please use Version 3.0.1

@aadrian
Copy link
Author

aadrian commented Aug 8, 2018

@robertoschwald @longwa yes, with 3.0.1 it works again :) .
Thank you for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants