Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Windows: Error when resolving relative deployments path from HardhatContext #1

Closed
RobertoSnap opened this issue Nov 10, 2020 · 6 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@RobertoSnap
Copy link
Contributor

image

packages/hardhat-react/src/TsMorhProject.ts:95

   const relativeDeploymentsPath = path.relative(
      this.hre.config.paths.react,
      this.hre.config.paths.deployments + "/" + currentNetwork
    );

packages/hardhat-react/src/TsMorhProject.ts:179

      deploymentFile: deploymentFile
            ? `${relativeDeploymentsPath}/${deploymentFile}`
            : undefined,

Does not work in Windows.

Need to try and create a fix and run it on windows.

Fix needs to be created in
https://github.com/symfoni/hardhat-plugins

@RobertoSnap
Copy link
Contributor Author

@ramvi

@RobertoSnap
Copy link
Contributor Author

Test version 0.0.46-alpha.0

@ramvi
Copy link
Member

ramvi commented Nov 10, 2020

no go

@Datakunskap
Copy link

HELP!!!!

@RobertoSnap
Copy link
Contributor Author

Fixed in version 0.1.7 with commit symfoni/symfoni-monorepo@5d13455

Can you try with this version @DrScatman @ramvi

@ramvi
Copy link
Member

ramvi commented Jan 13, 2021

Works perfectly!

@ramvi ramvi closed this as completed Jan 13, 2021
@ramvi ramvi added bug Something isn't working good first issue Good for newcomers labels Jan 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants