Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected BC in 5.4.13 #174

Closed
steffenbrand opened this issue Aug 19, 2022 · 3 comments
Closed

Unexpected BC in 5.4.13 #174

steffenbrand opened this issue Aug 19, 2022 · 3 comments

Comments

@steffenbrand
Copy link

steffenbrand commented Aug 19, 2022

You merged this commit including a BC in the Release 5.4.13.

Please note we have two BC break here:
- We now require `tar` instead of `gzip`
- The installer now puts the installer into `$HOME/.symfony5`

Maybe this would have been better in a major release.
Or at least it could be documented somewhere in a minor release?
It broke my builds this morning.

Repeating the output of the command that caused the failure
          +build-dev *failed* | --> RUN curl -sS https://get.symfony.com/cli/installer | bash && mv /root/.symfony/bin/symfony /usr/local/bin/symfony
          +build-dev *failed* | Symfony CLI installer
          +build-dev *failed* | 
          +build-dev *failed* | Environment check
          +build-dev *failed* |   [*] cURL is installed
          +build-dev *failed* |   [*] Tar is installed
          +build-dev *failed* |   [*] Git is installed
          +build-dev *failed* |   [*] Your architecture (amd64) is supported
          +build-dev *failed* | 
          +build-dev *failed* | Download
          +build-dev *failed* |   Downloading https://github.com/symfony-cli/symfony-cli/releases/latest/download/symfony-cli_linux_amd64.tar.gz...
          +build-dev *failed* |   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
          +build-dev *failed* |                                  Dload  Upload   Total   Spent    Left  Speed
          +build-dev *failed* |   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
          +build-dev *failed* |   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
          +build-dev *failed* | 100 5105k  100 5105k    0     0  6704k      0 --:--:-- --:--:-- --:--:-- 31.5M
          +build-dev *failed* |   Uncompress binary...
          +build-dev *failed* |   Installing the binary into your home directory...
          +build-dev *failed* |   The binary was saved to: /root/.symfony5/bin/symfony
          +build-dev *failed* | 
          +build-dev *failed* | The Symfony CLI was installed successfully!
          +build-dev *failed* | 
          +build-dev *failed* | Use it as a local file:
          +build-dev *failed* |   /root/.symfony5/bin/symfony
          +build-dev *failed* | 
          +build-dev *failed* | Or add the following line to your shell configuration file:
          +build-dev *failed* |   export PATH="$HOME/.symfony5/bin:$PATH"
          +build-dev *failed* | 
          +build-dev *failed* | Or install it globally on your system:
          +build-dev *failed* |   mv /root/.symfony5/bin/symfony /usr/local/bin/symfony
          +build-dev *failed* | 
          +build-dev *failed* | Then start a new shell and run 'symfony'
          +build-dev *failed* | mv: can't rename '/root/.symfony/bin/symfony': No such file or directory
          +build-dev *failed* | Command /bin/sh -c 'curl -sS https://get.symfony.com/cli/installer | bash && mv /root/.symfony/bin/symfony /usr/local/bin/symfony' failed with exit code 1
          +build-dev *failed* |           +build-dev *failed* | ERROR: Command exited with non-zero code: RUN curl -sS https://get.symfony.com/cli/installer | bash && mv /root/.symfony/bin/symfony /usr/local/bin/symfony

At least the hint was right above the error 😁

@steffenbrand
Copy link
Author

steffenbrand commented Aug 19, 2022

For those having the same issue, the --install-dir option might be a more "stable" solution for the future:

RUN curl -sS https://get.symfony.com/cli/installer | bash -s -- --install-dir=/root/.symfony/bin/symfony \
    && mv /root/.symfony/bin/symfony /usr/local/bin/symfony

@cawolf
Copy link

cawolf commented Aug 22, 2022

Broke our CI builds as well, but the --install-dir option would have prevented that. I did not find that installation option documented anywhere in the Symfony documentation, maybe this is worth a paragraph.

@fabpot
Copy link
Contributor

fabpot commented Feb 24, 2023

Sorry for the inconvenience.
Bumping to a major version would not have helped as this is a script used outside of the binary.

@fabpot fabpot closed this as completed Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants