[FileSystem] remove symlinks under windows

symfony · Jun 13, 2012 · e1a5395 · e1a5395
1 parent e1f7c29
commit e1a5395
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/Filesystem.php b/Filesystem.php
@@ -94,7 +94,9 @@ public function remove($files)
 
             if (is_dir($file) && !is_link($file)) {
                 $this->remove(new \FilesystemIterator($file));
-
+                rmdir($file);
+            } elseif(is_dir($file) && is_link($file)) {
+                // https://bugs.php.net/bug.php?id=52176 windows thinks symlinks are directories
                 rmdir($file);
             } else {
                 unlink($file);

diff --git a/Tests/FilesystemTest.php b/Tests/FilesystemTest.php
@@ -421,6 +421,20 @@ public function testSymlink()
         $this->assertTrue(is_link($link));
         $this->assertEquals($file, readlink($link));
     }
+
+    /**
+     * @depends testSymlink 
+     */
+    public function testRemoveSymlink()
+    {
+        $this->markAsSkippedIfSymlinkIsMissing();
+
+        $link = $this->workspace.DIRECTORY_SEPARATOR.'link';
+
+        $this->filesystem->remove($link);
+
+        $this->assertTrue(!is_link($link));
+    }
 
     public function testSymlinkIsOverwrittenIfPointsToDifferentTarget()
     {